Re: It seems to miss PQclear function - Mailing list pgadmin-hackers

From Dave Page
Subject Re: It seems to miss PQclear function
Date
Msg-id 937d27e10909160253j794db60aqaf0d71756dc38d64@mail.gmail.com
Whole thread Raw
In response to It seems to miss PQclear function  (Quan Zongliang <quanzongliang@gmail.com>)
List pgadmin-hackers
Yup, looks that way. Patch applied.

Thanks!

On Tue, Sep 15, 2009 at 6:08 AM, Quan Zongliang <quanzongliang@gmail.com> wrote:
> hi all
>
> In ExecuteVoid function of pgConn class:
>    // Check for errors
>    if (lastResultStatus != PGRES_TUPLES_OK &&
>        lastResultStatus != PGRES_COMMAND_OK)
>    {
>        LogError(!reportError);
>        return false;
>    }
>
> Shoud be:
>    // Check for errors
>    if (lastResultStatus != PGRES_TUPLES_OK &&
>        lastResultStatus != PGRES_COMMAND_OK)
>    {
>        LogError(!reportError);
>        PQclear(qryRes);
>        return false;
>    }
>
> right?
>
>
> -----------------------------------------------
> Quan Zongliang
> quanzongliang@gmail.com
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by dpage: r8036 - branches/REL-1_10_0_PATCHES/pgadmin3/pgadmin/db
Next
From: Rudi Schmitz
Date:
Subject: Desktop and xpm file in Centos 5 compile