It seems to miss PQclear function - Mailing list pgadmin-hackers

From Quan Zongliang
Subject It seems to miss PQclear function
Date
Msg-id 20090915125257.924A.4125B4E5@gmail.com
Whole thread Raw
Responses Re: It seems to miss PQclear function  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
hi all

In ExecuteVoid function of pgConn class:
    // Check for errors
    if (lastResultStatus != PGRES_TUPLES_OK &&
        lastResultStatus != PGRES_COMMAND_OK)
    {
        LogError(!reportError);
        return false;
    }

Shoud be:
    // Check for errors
    if (lastResultStatus != PGRES_TUPLES_OK &&
        lastResultStatus != PGRES_COMMAND_OK)
    {
        LogError(!reportError);
        PQclear(qryRes);
        return false;
    }

right?


-----------------------------------------------
Quan Zongliang
quanzongliang@gmail.com

Attachment

pgadmin-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [pgadmin-support] Possible simple enhancement
Next
From: Guillaume Lelarge
Date:
Subject: Re: [pgadmin-support] Possible simple enhancement