Re: Gin page deletion bug - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Gin page deletion bug
Date
Msg-id 9195.1383930866@sss.pgh.pa.us
Whole thread Raw
In response to Re: Gin page deletion bug  (Heikki Linnakangas <hlinnakangas@vmware.com>)
Responses Re: Gin page deletion bug  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Heikki Linnakangas <hlinnakangas@vmware.com> writes:
> I came up with the attached fix. In a nutshell, when walking along a 
> right-link, the new page is locked before releasing the lock on the old 
> one. Also, never delete the leftmost branch of a posting tree. I believe 
> these changes are sufficient to fix the problem, because of the way the 
> posting tree is searched:

This seems reasonable, but I wonder whether the concurrency discussion
shouldn't be in gist/README, rather than buried in a comment inside
ginDeletePage (not exactly the first place one would think to look IMO).
        regards, tom lane



pgsql-hackers by date:

Previous
From: Mike Blackwell
Date:
Subject: Re: stats for network traffic WIP
Next
From: Robert Haas
Date:
Subject: Re: logical changeset generation v6.5