RE: Re: [COMMITTERS] TOAST - Mailing list pgsql-hackers

From Mikheev, Vadim
Subject RE: Re: [COMMITTERS] TOAST
Date
Msg-id 8F4C99C66D04D4118F580090272A7A23018C45@SECTORBASE1
Whole thread Raw
Responses Re: Re: [COMMITTERS] TOAST
Re: Re: [COMMITTERS] TOAST
List pgsql-hackers
> The problem appears to be that DataFill() is invoked on the tuple
> after toasting, and it forces the infomask to zero, losing any
> transaction status bits that may have been there.  I think perhaps
> line 93 of heaptuple.c should be
> 
>     *infomask &= HEAP_XACT_MASK;
> 
> not
> 
>     *infomask = 0;
> 
> Comments anyone?

One should check all places from where DataFill called...

Btw, I've found that I unlocked buffer in heap_insert *after* WriteBuffer -
fixed.

2Jan - please note NO ELOG(ERROR)... comment in heap_update: can you move
toast
code below xlog one?

Vadim


pgsql-hackers by date:

Previous
From: The Hermit Hacker
Date:
Subject: Re: [ANNOUNCE] Re: proposed improvements to PostgreSQL license
Next
From: Tom Lane
Date:
Subject: Re: Re: [COMMITTERS] TOAST