Re: Bug #758: show_planner_stats does not work for new PREPARE calls - Mailing list pgsql-bugs

From Neil Conway
Subject Re: Bug #758: show_planner_stats does not work for new PREPARE calls
Date
Msg-id 87vg55a1g2.fsf@mailbox.samurai.com
Whole thread Raw
In response to Re: Bug #758: show_planner_stats does not work for new PREPARE calls  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bug #758: show_planner_stats does not work for new PREPARE  (Bruce Momjian <pgman@candle.pha.pa.us>)
Re: Bug #758: show_planner_stats does not work for new PREPARE  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-bugs
Tom Lane <tgl@sss.pgh.pa.us> writes:
> I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> moment, but they used to be used; I think the correct response is to
> put back the missing counter increments, not rip out the counters.

Ok, fair enough. It's worth noting that they've been broken for a
while -- for example, the HashJoin counter increments were broken when
you comitted r1.20 of executor/nodeHashJoin.c in May of '99.

I've attached a revised patch that doesn't remove the counters (but
doesn't increment them either: I'm not sure of all the places where
the counter should be incremented).

Cheers,

Neil

--
Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC

Attachment

pgsql-bugs by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Postgres storing time in strange manner
Next
From: Tom Lane
Date:
Subject: Re: Postgres storing time in strange manner