[ Sorry, removed previous version of patch from queue.]
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---------------------------------------------------------------------------
---------------------------------------------------------------------------
Neil Conway wrote:
> Tom Lane <tgl@sss.pgh.pa.us> writes:
> > I'm not sure why NDirectFileRead/NDirectFileWrite are unused at the
> > moment, but they used to be used; I think the correct response is to
> > put back the missing counter increments, not rip out the counters.
>
> Ok, fair enough. It's worth noting that they've been broken for a
> while -- for example, the HashJoin counter increments were broken when
> you comitted r1.20 of executor/nodeHashJoin.c in May of '99.
>
> I've attached a revised patch that doesn't remove the counters (but
> doesn't increment them either: I'm not sure of all the places where
> the counter should be incremented).
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilc@samurai.com> || PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
