Re: Should contrib modules install .h files? - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Should contrib modules install .h files?
Date
Msg-id 87po02m0bh.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: Should contrib modules install .h files?  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Should contrib modules install .h files?  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> This installs to $(includedir_server)/$(MODULEDIR)/$MODULE/file.h
 >> (e.g. include/server/extension/hstore/hstore.h for an actual
 >> example), and errors if HEADERS_xxx is defined for anything that's
 >> not a module listed in MODULES or MODULE_big.

 Tom> I've not studied this patch in any great detail, but the basic
 Tom> plan seems sane. However, don't we also need to teach the MSVC
 Tom> build system about this?

Yes, also needs to update the pgxs docs.

Looking at the windows build, is there anything needed beyond adding a
check for the HEADERS* vars in Install.pm?

-- 
Andrew (irc:RhodiumToad)


pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: TupleTableSlot abstraction
Next
From: Etsuro Fujita
Date:
Subject: Re: Expression errors with "FOR UPDATE" and postgres_fdw with partitionwise join enabled.