Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction - Mailing list pgsql-hackers

From Arseny Sher
Subject Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction
Date
Msg-id 87mv5v50gt.fsf@ars-thinkpad
Whole thread Raw
In response to Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the sametransaction  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the sametransaction
List pgsql-hackers
Tree view 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:

> Here is a simple patch that fixes this, based on my original proposal
> point #4.

I checked, it passes the tests and solves the problem. However, isn't
this

+        if (slotname || !subenabled)

is a truism? Is it possible that subscription has no slot but still
enabled?

Besides, we can avoid stopping the workers if subscription has no
associated replication origin, though this probably means that
subscription was broken by user and is not worth it.

--
Arseny Sher


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Rosser Schwarz
Date:
Subject: Re: [HACKERS] Patch: add --if-exists to pg_recvlogical
Next
From: Peter Geoghegan
Date:
Subject: Re: [HACKERS] The case for removing replacement selection sort