Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: Fix a portability bug (ye olde not casting a argument - Mailing list pgsql-committers

From Gregory Stark
Subject Re: pgsql: Fix a portability bug (ye olde not casting a argument
Date
Msg-id 87lkb5o7j1.fsf@oxford.xeocode.com
Whole thread Raw
In response to pgsql: Fix a portability bug (ye olde not casting a argument  (tgl@postgresql.org (Tom Lane))
Responses Re: pgsql: Fix a portability bug (ye olde not casting a argument  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
Tree view 
"Tom Lane" <tgl@postgresql.org> writes:

> Log Message:
> -----------
> Fix a portability bug (ye olde not casting a <ctype.h> argument to
> unsigned char).  Fortunately we still have buildfarm machines that
> will flag this.  Seems to be new in CVS HEAD, so no backpatch.

Should we add buildfarm animals which compile with -fsigned-chars and
-funsigned-chars in addition to the per-architecture defaults? Does that
guarantee that we'll trigger this warning or does it not help?

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

pgsql-committers by date:

Previous
From: cunha17@pgfoundry.org (User Cunha17)
Date:
Subject: snapshot - src: Initial release of the support on Sybase, ODBC and
Next
From: cunha17@pgfoundry.org (User Cunha17)
Date:
Subject: snapshot - src: Fixing ODBC function names.