Re: pgsql: Fix a portability bug (ye olde not casting a argument - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix a portability bug (ye olde not casting a argument
Date
Msg-id 21310.1190035997@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix a portability bug (ye olde not casting a argument  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-committers
Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@postgresql.org> writes:
>> Fix a portability bug (ye olde not casting a <ctype.h> argument to
>> unsigned char).  Fortunately we still have buildfarm machines that
>> will flag this.  Seems to be new in CVS HEAD, so no backpatch.

> Should we add buildfarm animals which compile with -fsigned-chars and
> -funsigned-chars in addition to the per-architecture defaults? Does that
> guarantee that we'll trigger this warning or does it not help?

Wouldn't help AFAICS.

            regards, tom lane

pgsql-committers by date:

Previous
From: cunha17@pgfoundry.org (User Cunha17)
Date:
Subject: snapshot - src: Missing newline.
Next
From: okbob@pgfoundry.org (User Okbob)
Date:
Subject: plpsm - plpgpsm: resync with last plpgsql updates correct format for