Re: [sqlsmith] crashes in RestoreSnapshot on hot standby - Mailing list pgsql-hackers

From Andreas Seltenreich
Subject Re: [sqlsmith] crashes in RestoreSnapshot on hot standby
Date
Msg-id 87k2h5synz.fsf@credativ.de
Whole thread Raw
In response to Re: [sqlsmith] crashes in RestoreSnapshot on hot standby  (Amit Kapila <amit.kapila16@gmail.com>)
Responses Re: [sqlsmith] crashes in RestoreSnapshot on hot standby  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Amit Kapila writes:
> On Fri, Jul 1, 2016 at 9:38 AM, Thomas Munro <thomas.munro@enterprisedb.com> wrote:
>> Or maybe just like this?
>>
>> -               snapshot->subxip = snapshot->xip + serialized_snapshot->xcnt;
>> +               snapshot->subxip = ((TransactionId *) (snapshot + 1)) +
>> +                       serialized_snapshot->xcnt;
>>
>
> This way it looks better to me.  Thanks for the patch.

I no longer see these crashes when testing with the patch applied.

thanks,
Andreas



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Forthcoming SQL standards about JSON and Multi-Dimensional Arrays (FYI)
Next
From: Craig Ringer
Date:
Subject: Re: Is a UDF binary portable across different minor releases and PostgreSQL distributions?