Re: draft patch for strtof() - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: draft patch for strtof()
Date
Msg-id 87a7k0jbaq.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: draft patch for strtof()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: draft patch for strtof()  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 >> (FWIW, I'm running the patch on gaur's host, just to confirm it
 >> does what you expect.  Should have an answer in an hour or so ...)

 Tom> It does --- it compiles cleanly, and the float4 output matches
 Tom> float4-misrounded-input.out.

Well I'm glad _something_ works.

Because it turns out that Windows (at least the version running on
Appveyor) completely fucks this up; strtof() is apparently returning
infinity or zero _without setting errno_ for values out of range for
float: input of "10e70" returns +inf with no error, input of "10e-70"
returns (exactly) 0.0 with no error.

*facepalm*

Any windows-users have any idea about this?

-- 
Andrew (irc:RhodiumToad)


pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Next
From: Amit Langote
Date:
Subject: Re: speeding up planning with partitions