Re: prevent immature WAL streaming - Mailing list pgsql-hackers

From Dagfinn Ilmari Mannsåker
Subject Re: prevent immature WAL streaming
Date
Msg-id 8735o4qgrp.fsf@wibble.ilmari.org
Whole thread Raw
In response to Re: prevent immature WAL streaming  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> Also, I think we want
>
> -ok($initfile != $endfile, "$initfile differs from $endfile");
> +ok($initfile ne $endfile, "$initfile differs from $endfile");
>
> The existing coding works as long as all characters of these
> WAL segment names happen to be decimal digits, but ...

Even better style (IMO) would be:

  isnt($initfile, $endfile, "WAL file name has changed");

Or some other more descriptive message of _why_ it should have changed.

- ilmari



pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Removed unused import modules from tap tests
Next
From: Michael Paquier
Date:
Subject: Re: Add jsonlog log_destination for JSON server logs