Re: prevent immature WAL streaming - Mailing list pgsql-hackers

From Tom Lane
Subject Re: prevent immature WAL streaming
Date
Msg-id 1372189.1636499287@sss.pgh.pa.us
Whole thread Raw
In response to Re: prevent immature WAL streaming  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: prevent immature WAL streaming
Re: prevent immature WAL streaming
List pgsql-hackers
I wrote:
> Seems like this hasn't fixed the problem: skink still fails on
> this test occasionally.
> #   Failed test '000000010000000000000002 differs from 000000010000000000000002'
> #   at t/026_overwrite_contrecord.pl line 61.

This is still happening off and on, which makes it look like a
timing-sensitive problem.  Confirming that, I can make it fail
every time by adding a long sleep just ahead of where
026_overwrite_contrecord.pl captures $initfile.  On reflection
I think the problem is obvious: if autovacuum does anything
concurrently with the test's startup portion, it will cause the
carefully-established WAL insertion point to move into the
next segment.  I propose to add "autovacuum = off" to the
test's postmaster configuration.

Also, I think we want

-ok($initfile != $endfile, "$initfile differs from $endfile");
+ok($initfile ne $endfile, "$initfile differs from $endfile");

The existing coding works as long as all characters of these
WAL segment names happen to be decimal digits, but ...

            regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Clean up build warnings of plperl with clang-12+
Next
From: Peter Smith
Date:
Subject: Re: row filtering for logical replication