Re: test/example does not support win32. - Mailing list pgsql-hackers

From Hiroshi Saito
Subject Re: test/example does not support win32.
Date
Msg-id 870E860C34384616973A0ED526D0DDF7@acer08f817a9b5
Whole thread Raw
In response to test/example does not support win32.  ("Hiroshi Saito" <z-saito@guitar.ocn.ne.jp>)
Responses Re: test/example does not support win32.  (Magnus Hagander <magnus@hagander.net>)
Re: test/example does not support win32.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Hi Andrew-san.

This saves a windows users.
I appreciate your suggestion.
Thanks!

P.S)
I often use by the test by nmake at the time of independent creation of libpq.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Andrew Dunstan" <andrew@dunslane.net>


>
>
> Hiroshi Saito wrote:
>> Hi Andrew-san.
>>
>> Although this is a standard in windows.
>>
>> *** testlibpq2.c.orig   Wed Dec 30 13:19:03 2009
>> --- testlibpq2.c        Thu Dec 31 00:52:52 2009
>> ***************
>> *** 24,34 ****
>> --- 24,39 ----
>>   *
>>   *     INSERT INTO TBL1 VALUES (10);
>>   */
>> +
>> + #ifdef WIN32
>> + #include <windows.h>
>> + #endif
>>  #include <stdio.h>
>>  #include <stdlib.h>
>>  #include <string.h>
>>  #include <errno.h>
>>  #include <sys/time.h>
>> + #include <sys/types.h>
>>  #include "libpq-fe.h"
>>
>>  static void
>>
>> Does this become the standard which you consider?
>> or #IFDEF Isn't it allowed?
>>
>>
> I certainly think we can use ifdefs. This addition seems OK to me at
> first glance. Does it solve the problem you encountered?
>
> cheers
>
> andrew
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Stats for inheritance trees
Next
From: Magnus Hagander
Date:
Subject: Re: test/example does not support win32.