Re: [PATCHES] Double Backslash example patch - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Double Backslash example patch
Date
Msg-id 8692.1071684455@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Double Backslash example patch  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [PATCHES] Double Backslash example patch
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> I see that psql/mainloop.c contains this comment:
>  * FIXME: rewrite this whole thing with flex
> Is now the time to do that?

If you feel like giving it a shot, ain't nobody gonna stand in your way.
MainLoop() is well past the level of unmaintainability IMHO (which is
why I'd not tried to touch it in the original quick patch).

I'm not totally convinced that flex can do the job, but in any case a
ground-up redesign for legibility might be the only cure.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [BUGS] pg_service.conf ignores dbname parameter
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] Double Backslash example patch