Re: [PATCHES] Double Backslash example patch - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: [PATCHES] Double Backslash example patch
Date
Msg-id 3FE0A53B.6020704@dunslane.net
Whole thread Raw
In response to Re: [PATCHES] Double Backslash example patch  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane wrote:

>Andrew Dunstan <andrew@dunslane.net> writes:
>  
>
>>I see that psql/mainloop.c contains this comment:
>> * FIXME: rewrite this whole thing with flex
>>Is now the time to do that?
>>    
>>
>
>If you feel like giving it a shot, ain't nobody gonna stand in your way.
>MainLoop() is well past the level of unmaintainability IMHO (which is
>why I'd not tried to touch it in the original quick patch).
>
>I'm not totally convinced that flex can do the job, but in any case a
>ground-up redesign for legibility might be the only cure.
>
>  
>

I will take a look - no guarantees though. I agree that flex might well 
end up making things more obscure than less.

Keeping track of open quote operators to make sure we have proper 
nesting and closing looks like it might be a bit messy, but doable.

cheers

andrew



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [PATCHES] Double Backslash example patch
Next
From: Tilo Schwarz
Date:
Subject: time interval behaviour seems odd