Re: pgbench - use pg logging capabilities - Mailing list pgsql-hackers

On 2020-01-08 15:12, Michael Paquier wrote:
> On Wed, Jan 08, 2020 at 02:27:46PM +0100, Peter Eisentraut wrote:
>> Committed.
> 
> That was fast.
> 
> -   if (debug)
> +   if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
>      {
> I am surprised that you kept this one,

I'm not happy about it, but it seems OK for now.  We can continue to 
improve here.

> while syntax_error() has been
> changed in a more modular way.

I don't follow what you mean by that.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services