Re: PLy_malloc and plperl mallocs - Mailing list pgsql-hackers

From Tom Lane
Subject Re: PLy_malloc and plperl mallocs
Date
Msg-id 8580.1290914890@sss.pgh.pa.us
Whole thread Raw
In response to PLy_malloc and plperl mallocs  (Jan Urbański <wulczer@wulczer.org>)
Responses Re: PLy_malloc and plperl mallocs
List pgsql-hackers
Jan Urbański <wulczer@wulczer.org> writes:
> I noticed that PL/Python uses a simple wrapper around malloc that does
> ereport(FATAL) if malloc returns NULL. I find it a bit harsh, don't we
> normally do ERROR if we run out of memory?

> And while looking at how PL/Perl does these things I find that one
> failed malloc (in compile_plperl_function) throws an ERROR, and the rest
> (in plperl_spi_prepare) are simply unguarded...

> I guess PL/Python should stop throwing FATAL errors and PL/Perl should
> get its own malloc_or_ERROR helper and start using that.

The real question is why they're not using palloc instead.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Report: Linux huge pages with Postgres
Next
From: Bruce Momjian
Date:
Subject: Re: profiling connection overhead