PLy_malloc and plperl mallocs - Mailing list pgsql-hackers

From Jan Urbański
Subject PLy_malloc and plperl mallocs
Date
Msg-id 4CF19FC9.60309@wulczer.org
Whole thread Raw
Responses Re: PLy_malloc and plperl mallocs
List pgsql-hackers
I noticed that PL/Python uses a simple wrapper around malloc that does
ereport(FATAL) if malloc returns NULL. I find it a bit harsh, don't we
normally do ERROR if we run out of memory?

And while looking at how PL/Perl does these things I find that one
failed malloc (in compile_plperl_function) throws an ERROR, and the rest
(in plperl_spi_prepare) are simply unguarded...

I guess PL/Python should stop throwing FATAL errors and PL/Perl should
get its own malloc_or_ERROR helper and start using that.

Cheers,
Jan


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: What do these terms mean in the SOURCE CODE?
Next
From: Bruce Momjian
Date:
Subject: Re: s/LABEL/VALUE/ for ENUMs