Re: Use IsA() macro instead of nodeTag comparison - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Use IsA() macro instead of nodeTag comparison
Date
Msg-id 84cdb63c-b4cd-457f-812f-d32c062d5b0b@iki.fi
Whole thread Raw
In response to Re: Use IsA() macro instead of nodeTag comparison  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: Use IsA() macro instead of nodeTag comparison
List pgsql-hackers
On 08/01/2026 15:10, Kirill Reshke wrote:
> On Thu, 8 Jan 2026 at 17:31, Shinya Kato <shinya11.kato@gmail.com> wrote:
>> In copy.c, nodeTag was being compared directly, so I replaced it with
>> the IsA() predicate macro for consistency.
> 
> Oops. Looks like oversight in 6c8f670. This is indeed case where we
> should use IsA()
> 
>> I verified that there are no other direct comparisons left by running
>> the following command:
>> $ git grep "nodeTag(.*) =="
> 
> Yep, look like this is the only case in copy.c

Pushed, thanks

- Heikki




pgsql-hackers by date:

Previous
From: Antonin Houska
Date:
Subject: Re: Adding REPACK [concurrently]
Next
From: Kirill Reshke
Date:
Subject: Re: GIN pageinspect support for entry tree and posting tree