Re: Adding REPACK [concurrently] - Mailing list pgsql-hackers

Antonin Houska <ah@cybertec.at> wrote:

> Antonin Houska <ah@cybertec.at> wrote:
> 
> > Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> 
> > > If we do indeed need this,
> > > then perhaps it should be done after ReorderBufferProcessXid().
> > 
> > ... and after SnapBuildProcessChange(). Thus the changes being discussed here
> > should be removed from the patch. I'll do that in the next version. Thanks.
> 
> Actually the check of XLH_DELETE_NO_LOGICAL should not be discarded. I think
> it should be added to DecodeDelete().

v29 tries to fix the problem.

Besides that, it reflects the recent Mihail's comments [1], [2].

[1]
https://www.postgresql.org/message-id/CADzfLwXp4c-MJx7yVDxAGNNxPbX4o9dqyivxavtHvmUsdXYqBQ@mail.gmail.com
[2] https://www.postgresql.org/message-id/CADzfLwWNz_jwi7KVOmJ9D97+zwxsiwDSqSUUJ9oqUCOqkbGnRA@mail.gmail.com

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com