Re: Inconsistencies around defining FRONTEND - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Inconsistencies around defining FRONTEND
Date
Msg-id 840806.1661298600@sss.pgh.pa.us
Whole thread Raw
In response to Re: Inconsistencies around defining FRONTEND  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Inconsistencies around defining FRONTEND
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Aug 23, 2022 at 7:24 PM Andres Freund <andres@anarazel.de> wrote:
>> Just to make sure I understand - you're just trying to get rid of the #define
>> frontends, not the -DFRONTENDs passed in from the Makefile? Because afaics we
>> still need those, correct?

> Oh, yeah, this only fixes the #define ones. But maybe fixing the other
> ones with a similar approach would be possible?

> I really don't see why we should tolerate having #define FRONTEND in
> more than once place.

src/port and src/common really need to do it like that (ie pass in
the -D switch) so that the identical source file can be built
both ways.  Maybe we could get rid of -DFRONTEND in other places,
like pg_rewind and pg_waldump.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Next
From: David Rowley
Date:
Subject: Re: shadow variables - pg15 edition