Re: Docs for refresh materialized view concurrently - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Docs for refresh materialized view concurrently
Date
Msg-id 82568.1559410259@sss.pgh.pa.us
Whole thread Raw
In response to Docs for refresh materialized view concurrently  (Jeremy Finzel <finzelj@gmail.com>)
List pgsql-hackers
Jeremy Finzel <finzelj@gmail.com> writes:
> I've not submitted a patch before, and have a few suggestions I'd like
> feedback on before I write one (for the docs only).

OK ...

> First, even this summary looks untrue:
> REFRESH MATERIALIZED VIEW — replace the contents of a materialized view.

Agreed.  I'd just make it say "update the contents...", personally.
More words are not better in command summaries.

> Also, the Description part has the same inaccuracy:
> "completely replaces the contents of a materialized view.....The old
> contents are discarded."

Yeah, that just wasn't updated :-(

> On a different note, none of the documentation on materialized views notes
> that they can only be LOGGED.  This should be noted,

Also agreed.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: coverage increase for worker_spi
Next
From: Michael Paquier
Date:
Subject: Custom table AMs need to include heapam.h because of BulkInsertState