Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block
Date
Msg-id 8247.1385482959@sss.pgh.pa.us
Whole thread Raw
In response to Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Suggestion: Issue warning when calling SET TRANSACTION outside transaction block  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> On Mon, Nov 25, 2013 at 10:04:19PM -0500, Robert Haas wrote:
>> But the documentation says:
>> 
>> -   Issuing <command>ABORT</> when not inside a transaction does
>> -   no harm, but it will provoke a warning message.
>> +   Issuing <command>ABORT</> outside of a transaction block has no effect.
>> 
>> Those things are not the same.

> Uh, I ended up mentioning "no effect" to highlight it does nothing,
> rather than mention a warning.  Would people prefer I say "warning"?  Or
> should I say "issues a warning because it has no effect" or something? 
> It is easy to change.

I'd revert the change Robert highlights above.  ISTM you've changed the
code to match the documentation; why would you then change the docs?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: UNION ALL on partitioned tables won't use indices.
Next
From: Tom Lane
Date:
Subject: Re: Extension Templates S03E11