Re: Serverside SNI support in libpq - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Serverside SNI support in libpq
Date
Msg-id 80F4F8F4-8E4F-4B6F-866B-D837057C1192@yesql.se
Whole thread Raw
In response to Re: Serverside SNI support in libpq  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
> On 1 Sep 2025, at 03:58, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Aug 27, 2025 at 09:49:34PM +0200, Daniel Gustafsson wrote:
>> When looking into why the SNI tests failed on Windows I think I found a
>> pre-existing issue that we didn't have tests for, which my patch added tests
>> for and thus broke.
>>
>> The test I added was to check restarting and reloading with ssl passphrase
>> commands (which we do have testcoverage for) with a subsequent connection test
>> to ensure it didn't just work to start the cluster.
>
> Would this part be better if extracted from the main patch and then
> backpatched?  Even if not backpatched, a split would be cleaner on
> HEAD, I assume, leading to less fuzz with the main patch.

Yes, that's my plan, just wanted to float it here first to see if I was
thinking about it all wrong.  I will raise it on its own thread on -hackers.
The backpatchable portion is probably limited to a docs entry clarifying the
behaviour on Windows.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Use bool with synced field (src/include/replication/slot.h)
Next
From: Robert Haas
Date:
Subject: Re: Extension security improvement: Add support for extensions with an owned schema