Re: small explain patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: small explain patch
Date
Msg-id 8096.1020441522@sss.pgh.pa.us
Whole thread Raw
In response to Re: small explain patch  (Liam Stewart <liams@redhat.com>)
List pgsql-patches
Liam Stewart <liams@redhat.com> writes:
>> How would you feel about quoting only if necessary
>> (cf. quote_identifier)?

> That would work nicely. I didn't put the call to quote_identifier inside
> the stringStringInfo macro.

Actually, stringStringInfo seems entirely pointless here; the result of
RelationGetRelationName can't be NULL.  The other places where it's
being used seem pointless as well.  I removed it while applying your
patch...

            regards, tom lane

pgsql-patches by date:

Previous
From: Liam Stewart
Date:
Subject: Re: small explain patch
Next
From: Neil Conway
Date:
Subject: fix for typo in docs