Re: knngist patch support - Mailing list pgsql-hackers

From Tom Lane
Subject Re: knngist patch support
Date
Msg-id 8088.1266094738@sss.pgh.pa.us
Whole thread Raw
In response to Re: knngist patch support  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: knngist patch support
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> Just to be clear, I was intending this patch, at least, to be applied
> now.  I actually think there's a good argument that we should do at
> least this much for 9.0, namely that now is probably the time when
> there are the fewest outstanding patches that will be broken by this.
> If we try to apply this for the first 9.1 CommitFest, then (1) it'll
> have to be completely redone and (2) it'll force massive rebasing.

What I think we should do is not change SearchSysCache for 9.0,
but provide the SearchSysCacheN macros as syntactic sugar, and
go around and change (at least most of) the call sites to use the
macros.  This is clearly cleaner source code, and with that method
we'll still be ABI-compatible in 9.0 for anybody who doesn't fix their
source right away.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: knngist patch support
Next
From: Teodor Sigaev
Date:
Subject: Re: knngist patch support