Re: Refactor SSL test framework to support multiple TLS libraries - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Refactor SSL test framework to support multiple TLS libraries
Date
Msg-id 7A523793-C0D3-4191-A64A-24AFFD002974@yesql.se
Whole thread Raw
In response to Re: Refactor SSL test framework to support multiple TLS libraries  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Refactor SSL test framework to support multiple TLS libraries  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
> On 25 Mar 2021, at 00:26, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2021-Mar-25, Daniel Gustafsson wrote:
>
>> Attached is a v2 which addresses the comments raised on the main NSS thread, as
>> well as introduces named parameters for the server cert function to make the
>> test code easier to read.
>
> I don't like this patch.  I think your SSL::Server::OpenSSL and
> SSL::Server::NSS packages should be doing "use parent SSL::Server";
> having SSL::Server grow a line to "use" its subclass
> SSL::Server::OpenSSL and import its get_new_openssl_backend() method
> seems to go against the grain.

I'm far from skilled at Perl module inheritance but that makes sense, I'll take
a stab at that after some sleep and coffee.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Refactor SSL test framework to support multiple TLS libraries
Next
From: Jacob Champion
Date:
Subject: Re: Support for NSS as a libpq TLS backend