Postgres Pro
Downloads
Home   >   mailing lists

Re: report expected contrecord size - Mailing list pgsql-hackers

From Tom Lane
Subject Re: report expected contrecord size
Date
Msg-id 792244.1599168691@sss.pgh.pa.us
Whole thread Raw
In response to report expected contrecord size  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: report expected contrecord size  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
Tree view 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> A pretty minor issue: when reporting that WAL appears invalid because
> contrecord length doesn't match, we may as well print to the server log
> the value that we're expecting.  Patch attached.

ITYW

+                                      (long long) (total_len - gotlen),

just to be sure about what's getting casted to what.  Otherwise +1.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Parallel worker hangs while handling errors.
Next
From: Tom Lane
Date:
Subject: Re: Maximum password length