Re: [HACKERS] Minor correction in alter_table.sgml - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Minor correction in alter_table.sgml
Date
Msg-id 7854.1482418144@sss.pgh.pa.us
Whole thread Raw
Responses Re: [HACKERS] Minor correction in alter_table.sgml  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>> I had considered removing those but thought that some users might think
>> that they're only "altering" one table and therefore felt it made sense
>> to keep those explicitly listed.

> I agree with Stephen; it's not crystal clear from the user's POV that
> the command is altering two tables.  It's worth mentioning this
> explicitly; otherwise this is just a documented gotcha.

Well, it already is shown explicitly in the syntax summary.  The text
is simply trying to restate that in an easily remembered fashion, and
the more exceptions, the harder it is to remember.  You might as well
forget trying to provide a rule at all and just say something like
"Most forms of ALTER TABLE can be combined, except as shown in the
syntax diagram."

(Of course, maybe the question we ought to be asking here is why
ATTACH/DETACH PARTITION failed to go with the flow and be a
combinable action.)
        regards, tom lane



pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Minor correction in alter_table.sgml
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] Getting rid of "unknown error" in dblink and postgres_fdw