Re: pgsql: Remove BufFile's isTemp flag. - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Remove BufFile's isTemp flag.
Date
Msg-id 7741.1511634091@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove BufFile's isTemp flag.  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> I don't really see a point in doing this renaming in the first
> place. It's not like the Temp suffix has become inaccurate. I'd perhaps
> not add it in the green field, but I don't see a need to change an
> existing function name. If anything it seems confusing because you'd
> miss something when trivially searching the history / comparing
> branches.

It seems that the vote is 2-1 against renaming that function, so I've
committed Thomas' patch without that and with some additional
comment-smithing.
        regards, tom lane


pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Update buffile.h/.c comments for removal of non-temp option.
Next
From: Tom Lane
Date:
Subject: pgsql: Repair failure with SubPlans in multi-row VALUES lists.