Re: "make check" and pg_hba.conf - Mailing list pgsql-hackers

From Tom Lane
Subject Re: "make check" and pg_hba.conf
Date
Msg-id 7715.1476830977@sss.pgh.pa.us
Whole thread Raw
In response to Re: "make check" and pg_hba.conf  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
Jeff Janes <jeff.janes@gmail.com> writes:
> On Tue, Oct 18, 2016 at 2:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> No.  Why would you want that?  External connections to the test DB seem
>> like exactly what you *don't* want, for reproducibility's sake.

> I would want to do that so that the code dealing with password-based logins
> doesn't go completely untested by "make check", like it currently is.

Well, unless you create a user with a password and use that password to
log in, you're not performing much of a test.  Getting the hba entry
in there seems to me to be about the least of the worries for making
a usable test case.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jeff Janes
Date:
Subject: Re: "make check" and pg_hba.conf
Next
From: Claudio Freire
Date:
Subject: Re: Indirect indexes