Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4 - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Date
Msg-id 7642.1496210229@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Chapman Flack <chap@anastigmatix.net>)
List pgsql-hackers
Tree view 
Chapman Flack <chap@anastigmatix.net> writes:
> On 05/31/17 01:26, Tom Lane wrote:
>> Hm.  I think it would be better to use DatumGetInt32 here.  Arguably,
>> direct use of GET_4_BYTES and its siblings should only appear in
>> DatumGetFoo macros.

> Like so?

Looks promising offhand, but I'm too tired to check in detail right now.
        regards, tom lane

pgsql-hackers by date:

Previous
From: Chapman Flack
Date:
Subject: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Next
From: Kuntal Ghosh
Date:
Subject: Re: [HACKERS] "create publication..all tables" ignore 'partition notsupported' error