Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4 - Mailing list pgsql-hackers

From Chapman Flack
Subject Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Date
Msg-id 592E5ABF.8070706@anastigmatix.net
Whole thread Raw
In response to Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 05/31/17 01:26, Tom Lane wrote:
> Hm.  I think it would be better to use DatumGetInt32 here.  Arguably,
> direct use of GET_4_BYTES and its siblings should only appear in
> DatumGetFoo macros.

Like so? These are the 4 sites where {GET,SET}_n_BYTES got introduced
in 14cca1b (for consistency, though only the GET_4 case produces warnings).

-Chap

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4