Postgres Pro
Downloads
Home   >   mailing lists

Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Date
Msg-id 756.1285713433@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in  (Bruce Momjian <bruce@momjian.us>)
List pgsql-committers
Tree view 
Bruce Momjian <bruce@momjian.us> writes:
> OK, I used your idea for conversion directly to oid from the system
> catalogs, patch attached.  All the pg_controldata returned integers are
> defined as uint32 in pg_upgrade. Should I use atooid() for some of them
> and define some of them as OID?

No, I don't think so --- most of them are not in fact OIDs.  Probably
best to follow what pg_control.h declares them as.

            regards, tom lane

pgsql-committers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pgsql: In pg_upgrade, properly handle oids > 2^31 by using strtoul() in
Next
From: Bruce Momjian
Date:
Subject: pgsql: Have pg_upgrade use strtoul(), not strtol().