Re: use less space in xl_xact_commit patch - Mailing list pgsql-hackers

From Leonardo Francalanci
Subject Re: use less space in xl_xact_commit patch
Date
Msg-id 724317.97040.qm@web29013.mail.ird.yahoo.com
Whole thread Raw
In response to use less space in xl_xact_commit patch  (Leonardo Francalanci <m_lists@yahoo.it>)
Responses Re: use less space in xl_xact_commit patch
Re: use less space in xl_xact_commit patch
List pgsql-hackers
> With regards to the naming, I think it would be better if we  kept
> XLOG_XACT_COMMIT record exactly as it is now, and make the  second
> record an entirely new record called XLOG_XACT_COMMIT_FASTPATH.  That
> way we retain backwards compatibility.
>
> If you'd like to rework  like that please, otherwise I can take it from
> here if you'd  like.


I think I did it; while doing it, I think I've found a bug: I didn't update
"recoveryStopsHere". Please double check that, as I really don't
know what I'm doing there...
Should I also change the struct name from xl_xact_commit to
xl_xact_commit_fast_path?

> > How can I test it with "weird" stuff as subtransactions,  shared
> > cache invalidation messages...?
>
> make installcheck should  cover those.


Ok, all tests passed.
Attachment

pgsql-hackers by date:

Previous
From: Florian Pflug
Date:
Subject: Re: Patch - Debug builds without optimization
Next
From: Simon Riggs
Date:
Subject: Re: use less space in xl_xact_commit patch