Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Fix dumping pre-10 DBs by pg_dump10 if table "name" exists - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Fix dumping pre-10 DBs by pg_dump10 if table "name" exists
Date
Msg-id 7230.1509471761@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Fix dumping pre-10 DBs by pg_dump10 if table "name" exists  (Vitaly Burovoy <vitaly.burovoy@gmail.com>)
Responses Re: [HACKERS] Fix dumping pre-10 DBs by pg_dump10 if table "name" exists
List pgsql-hackers
Tree view 
Vitaly Burovoy <vitaly.burovoy@gmail.com> writes:
> I left an other "NULL::name AS rolname" at
> src/bin/pg_dump/pg_dump.c:2978 because can't check (remoteVersion <
> 90000) it and it is under strict "selectSourceSchema(fout,
> "pg_catalog");" schema set.

Yeah, there are quite a few unqualified casts in pg_dump, but AFAICS
all the rest are OK because the search_path is just pg_catalog.

But I did find psql's describe.c making a similar mistake :-(.
Pushed that along with your fix.
        regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Re: PANIC: invalid index offnum: 186 when processingBRIN indexes in VACUUM
Next
From: Simon Riggs
Date:
Subject: Re: [HACKERS] SQL procedures