Re: Generate pg_stat_get_* functions with Macros - Mailing list pgsql-hackers

From Drouvot, Bertrand
Subject Re: Generate pg_stat_get_* functions with Macros
Date
Msg-id 6aa3ca59-f2b0-0e10-ba3a-a44c4064c8cc@gmail.com
Whole thread Raw
In response to Re: Generate pg_stat_get_* functions with Macros  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Hi,

On 12/10/22 4:55 AM, Nathan Bossart wrote:
> On Fri, Dec 09, 2022 at 09:43:56PM -0500, Tom Lane wrote:
>> Presumably it could be silenced by removing the semicolons after
>> the new macro calls:
> 
>> The backslash after the last right brace means that the line
>> following that is part of the macro body.  This does no harm as
>> long as said line is blank ... but I think it's a foot-gun
>> waiting to bite somebody, because visually you'd think the macro
>> ends with the brace.  So I'd leave off that last backslash.
> 
> Indeed.  Patch attached.
> 

Oh right. Thanks Tom for the explanations and Nathan/Michael for the fix.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Speedup generation of command completion tags
Next
From: "Drouvot, Bertrand"
Date:
Subject: Re: Minimal logical decoding on standbys