Re: Generate pg_stat_get_* functions with Macros - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Generate pg_stat_get_* functions with Macros
Date
Msg-id 20221210035545.GA196116@nathanxps13
Whole thread Raw
In response to Re: Generate pg_stat_get_* functions with Macros  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Generate pg_stat_get_* functions with Macros  (Michael Paquier <michael@paquier.xyz>)
Re: Generate pg_stat_get_* functions with Macros  ("Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>)
List pgsql-hackers
On Fri, Dec 09, 2022 at 09:43:56PM -0500, Tom Lane wrote:
> Presumably it could be silenced by removing the semicolons after
> the new macro calls:

> The backslash after the last right brace means that the line
> following that is part of the macro body.  This does no harm as
> long as said line is blank ... but I think it's a foot-gun
> waiting to bite somebody, because visually you'd think the macro
> ends with the brace.  So I'd leave off that last backslash.

Indeed.  Patch attached.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Generate pg_stat_get_* functions with Macros
Next
From: David Rowley
Date:
Subject: Re: slab allocator performance issues