Re: Bizarre reindex_relation API - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Bizarre reindex_relation API
Date
Msg-id 6E6C4473-020D-477B-B90E-9B082AB66072@gmail.com
Whole thread Raw
In response to Bizarre reindex_relation API  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Apr 16, 2011, at 11:52 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Why in the world is reindex_relation defined like this?
>
> #define REINDEX_CHECK_CONSTRAINTS    0x1
> #define REINDEX_SUPPRESS_INDEX_USE    0x2
> extern bool reindex_relation(Oid relid, bool toast_too, int flags);
>
> Seems like a rational design would have folded toast_too in as another
> flag bit, instead of keeping it a separate argument.

I thought about that for roughly three minutes, decided there was something awkward about it that I no longer recall,
andit go. I don't object if you want to rejigger it. 

...Robert

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: MMAP Buffers
Next
From: Joshua Berkus
Date:
Subject: Re: Formatting Curmudgeons WAS: MMAP Buffers