Bizarre reindex_relation API - Mailing list pgsql-hackers

From Tom Lane
Subject Bizarre reindex_relation API
Date
Msg-id 2361.1302969167@sss.pgh.pa.us
Whole thread Raw
Responses Re: Bizarre reindex_relation API  (Noah Misch <noah@leadboat.com>)
Re: Bizarre reindex_relation API  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Why in the world is reindex_relation defined like this?

#define REINDEX_CHECK_CONSTRAINTS    0x1
#define REINDEX_SUPPRESS_INDEX_USE    0x2
extern bool reindex_relation(Oid relid, bool toast_too, int flags);

Seems like a rational design would have folded toast_too in as another
flag bit, instead of keeping it a separate argument.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Broken HOT chains in system catalogs
Next
From: Noah Misch
Date:
Subject: Re: Broken HOT chains in system catalogs