Re: external_pid_file not removed on postmaster exit - Mailing list pgsql-hackers

From Amit kapila
Subject Re: external_pid_file not removed on postmaster exit
Date
Msg-id 6C0B27F7206C9E4CA54AE035729E9C382851FB0E@szxeml509-mbs
Whole thread Raw
In response to external_pid_file not removed on postmaster exit  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: external_pid_file not removed on postmaster exit
List pgsql-hackers
>From: pgsql-hackers-owner@postgresql.org [pgsql-hackers-owner@postgresql.org] on behalf of Peter Eisentraut
[peter_e@gmx.net]
> Sent: Friday, July 27, 2012 10:39 AM

> It seems strange that the external_pid_file is never removed.  There is
> even a C comment about it:

> /* Should we remove the pid file on postmaster exit? */

> I think it should be removed with proc_exit hook just like the main
> postmaster.pid file.

external_pid_file is created first time when it is enabled in postgresql.conf
I think it should be removed once the parameter external_pid_file is unset;

Making handling of both postmaster.pid and external_pid_file same in terms of creation and removal may not be best
choice
as both have different purpose.



With Regards,
Amit Kapila.

pgsql-hackers by date:

Previous
From: Satoshi Nagayasu
Date:
Subject: Adding probes for smgr
Next
From: Bruce Momjian
Date:
Subject: Re: Using pg_upgrade on log-shipping standby servers