Re: [PATCHES] Bad bug in fopen() wrapper code - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: [PATCHES] Bad bug in fopen() wrapper code
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCEA0FBDF@algol.sollentuna.se
Whole thread Raw
In response to Re: [PATCHES] Bad bug in fopen() wrapper code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCHES] Bad bug in fopen() wrapper code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> > Attached patch sets the  O_CREAT option when appending to files.
>
> That looks correct, but I went looking to see if there were
> any other mistakes of the same ilk, and I'm wondering what
> the sense is in openFlagsToCreateFileFlags ... seems like
> it's ignoring O_EXCL in some combinations and not others.  Is
> that right?

That is part of the original open() code that Claudio did back for 8.0,
so it has definitly been working since then. I haven't really read into
the code, though... But a qiuck look doesn't show me any place wher eit
does ignore O_EXCL - which combination would that be?

//Magnus

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_regress starting postmaster
Next
From: "Magnus Hagander"
Date:
Subject: Re: pg_regress starting postmaster