Re: Patch: "View top" for editgrid - Mailing list pgadmin-hackers

From Magnus Hagander
Subject Re: Patch: "View top" for editgrid
Date
Msg-id 6BCB9D8A16AC4241919521715F4D8BCE6C7F48@algol.sollentuna.se
Whole thread Raw
In response to Patch: "View top" for editgrid  ("Magnus Hagander" <mha@sollentuna.net>)
List pgadmin-hackers
.. and once more, with the patch included. Three's a charm?

//mha



> -----Original Message-----
> From: pgadmin-hackers-owner@postgresql.org
> [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of
> Magnus Hagander
> Sent: Wednesday, January 25, 2006 7:53 PM
> To: pgadmin-hackers@postgresql.org
> Subject: Re: [pgadmin-hackers] Patch: "View top" for editgrid
>
> Per some comments from Dave on IM, updated version:
>
> * First one was broken and didn't apply ;-)
> * The menu still said "top 10 rows", from my testing. It's
> supposed to be 100, it is now.
> * Dave also suggested to store a history somewhere so it
> re-appears in the dropdown and as default on the menu. Let's
> consider that for future improvement though, and please
> consider this patch without it for now.
>
> //Magnus
>
>
> > -----Original Message-----
> > From: pgadmin-hackers-owner@postgresql.org
> > [mailto:pgadmin-hackers-owner@postgresql.org] On Behalf Of Magnus
> > Hagander
> > Sent: Wednesday, January 25, 2006 4:52 PM
> > To: pgadmin-hackers@postgresql.org
> > Subject: [pgadmin-hackers] Patch: "View top" for editgrid
> >
> > Hi!
> >
> > This patch adds a "view top 100" to the view menu. It's easy to add
> > more if we want to, I figured that was a good start (or
> should it be
> > higher?) I also put it at the top, because doing "view all" can
> > certainly kill your server ;-) I left the toolbar button, but maybe
> > that should be changed as well?
> >
> > Also, I moved the view data (now) submenu higher up ni the context
> > menu and tools menu. It's something you'd do a lot more
> often than for
> > example "new object", IMHO.
> >
> > The xrc edit may need to be fixed. It looked like crap for a while
> > (the validate button being half outside the dialog), but
> suddently it
> > started to look better without me changing anything in that
> file that
> > I could notice ;-) Suffice to say, I'm not really on good
> terms with
> > those flex grids etc. So if someone can look at that, please :)
> >
> > //Magnus
> >
>
> ---------------------------(end of
> broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faq
>

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin website translations - SPANISH
Next
From: svn@pgadmin.org
Date:
Subject: SVN Commit by andreas: r4970 - in trunk/pgadmin3/src: frm schema utils