Re: inefficient loop in StandbyReleaseLockList() - Mailing list pgsql-hackers

From Bossart, Nathan
Subject Re: inefficient loop in StandbyReleaseLockList()
Date
Msg-id 696759A4-C422-4BB7-B99A-E3DDB9B3A970@amazon.com
Whole thread Raw
In response to Re: inefficient loop in StandbyReleaseLockList()  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: inefficient loop in StandbyReleaseLockList()
Re: inefficient loop in StandbyReleaseLockList()
List pgsql-hackers
On 11/1/21, 9:58 AM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
> "Bossart, Nathan" <bossartn@amazon.com> writes:
>> Should there be a list_free(trgmNFA->queue) at the end of
>> transformGraph()?
>
> There could be, but that's visibly invoked only once per
> createTrgmNFAInternal call, so I didn't think it was worthwhile
> to do so (unlike the case for processState).  If we were concerned
> about leakage in that function, the hash table would be a far
> bigger issue.

Ah, I see it now.  The patch looks good to me, then.

Nathan


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: inefficient loop in StandbyReleaseLockList()
Next
From: "Bossart, Nathan"
Date:
Subject: Re: Predefined role pg_maintenance for VACUUM, ANALYZE, CHECKPOINT.