Re: inefficient loop in StandbyReleaseLockList() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: inefficient loop in StandbyReleaseLockList()
Date
Msg-id 1142780.1635785847@sss.pgh.pa.us
Whole thread Raw
In response to Re: inefficient loop in StandbyReleaseLockList()  ("Bossart, Nathan" <bossartn@amazon.com>)
Responses Re: inefficient loop in StandbyReleaseLockList()
List pgsql-hackers
"Bossart, Nathan" <bossartn@amazon.com> writes:
> On 10/31/21, 1:55 PM, "Tom Lane" <tgl@sss.pgh.pa.us> wrote:
>> 1. Attached is a proposed patch to get rid of the calls in trgm_regexp.c.

> Should there be a list_free(trgmNFA->queue) at the end of
> transformGraph()?

There could be, but that's visibly invoked only once per 
createTrgmNFAInternal call, so I didn't think it was worthwhile
to do so (unlike the case for processState).  If we were concerned
about leakage in that function, the hash table would be a far
bigger issue.

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Bossart, Nathan"
Date:
Subject: Re: inefficient loop in StandbyReleaseLockList()
Next
From: "Bossart, Nathan"
Date:
Subject: Re: inefficient loop in StandbyReleaseLockList()