Re: DTrace probes broken in HEAD on Solaris? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: DTrace probes broken in HEAD on Solaris?
Date
Msg-id 6913.1238199288@sss.pgh.pa.us
Whole thread Raw
In response to Re: DTrace probes broken in HEAD on Solaris?  (Robert Lor <Robert.Lor@Sun.COM>)
List pgsql-hackers
Robert Lor <Robert.Lor@Sun.COM> writes:
> Tom Lane wrote:
>> [ complaining about disabled probes not being no-ops ]

> 1) Only use if (foo_ENABLED()) test  for probes with expensive function 
> call/computation in arguments. This will keep the code clean, and we can 
> document this in the "Definine New Probes" section in the online doc.
> ...
> I prefer option 1 the most and 3 the least.

I got the same advice from the systemtap people, so we'll do it that
way.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: typedefs for indent
Next
From: Bruce Momjian
Date:
Subject: Re: PQinitSSL broken in some use casesf