Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.
Date
Msg-id 6796.1476461414@sss.pgh.pa.us
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Re: [COMMITTERS] pgsql: Extend framework from commit 53be0b1ad to report latch waits.  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Oct 14, 2016 at 8:33 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Not sure.  There's something to be said for the equivalence Peter
>> proposes above.  What you actually wanted, as I understood it, was
>> that "make world" plus "make check-world" should test absolutely
>> everything.  I don't have a problem with the idea that some bits
>> of test scaffolding don't get built until you do "make check-world".
>> The real problem here is that "make check-world" missed some tests,
>> which Peter agrees is a bug.

> No, the problem is that worker_spi has no tests, so 'make check-world'
> never tries to build it at all.  Something in the buildfarm does cause
> it to get built, though.

Well, if it has no tests *and* it's not getting installed, what's
the point of having it at all?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Jim Nasby
Date:
Subject: Re: make coverage-html on OS X
Next
From: Jim Nasby
Date:
Subject: Re: Renaming of pg_xlog and pg_clog