On 06.04.2020 19:40, Anastasia Lubennikova wrote:
> On 06.04.2020 16:49, Anastasia Lubennikova wrote:
>> New version of the patch is attached. I fixed several issues in the
>> check_for_changed_signatures().
>>
>> Now it passes check without "test_rename_catalog_objects" and fails
>> (generates script) with it. Test script pg_upgrade_ACL_test.sh
>> demonstrates this.
>>
>> The only known issue left is the usage of pg_identify_object(),
>> though I don't see a problem here with object types that this patch
>> involves.
>> As I updated the code, I will leave this patch in Need Review.
>>
> One more fix for free_acl_infos().
> Thanks to cfbot.
>
One more update.
In this version I rebased test patches, added some more comments, fixed
memory allocation issue and also removed code that handles ACLs on
languages. They require a lot of specific handling, while I doubt that
their signatures, which consist of language name only, are subject to
change in any future versions.
--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
